weaselab/conflict-set
1
Fork 1
Code Issues 6 Pull Requests Actions 1 Packages Releases 13 Activity

Replace test_fixup_256 with a regression test for the Node256 fixupMaxVersion false-Commit bug #90

Merged
andrew merged 2 commits from weaselbot/conflict-set:weaselbot/issue-89 into main 2026-10-27 19:33:19 +00:00
Conversation 2 Commits 2 Files Changed 1
-12
1 changed files with 0 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit c94e9aaee6 - Show all commits
test_conflict_set.py
-12
View File
@@ -222,18 +222,6 @@ def test_merge_child_node48():
cs.addWrites(1, write(b"\x00" * 8, b"\x00" * 10)) cs.addWrites(1, write(b"\x00" * 8, b"\x00" * 10))
def test_fixup_256():
# All children are written at the same version, so this test passes even
# if fixupMaxVersion only considers some of them. See
# test_fixup_256_heterogeneous_versions for that case.
with DebugConflictSet() as cs:
cs.addWrites(0, write(bytes([1])))
for i in range(256):
cs.addWrites(1, write(bytes([1, i])))
cs.addWrites(2, write(bytes([0]), bytes([1])))
cs.check(read(0, bytes([1]), bytes([2])))
def test_fixup_256_heterogeneous_versions(): def test_fixup_256_heterogeneous_versions():
# Regression test for issue #89: recomputing the maxVersion of a Node256 # Regression test for issue #89: recomputing the maxVersion of a Node256
andrew commented 2026-10-27 16:51:36 +00:00
Review
Copy link
Copy source

Just remove this test

Just remove this test
# must consider all of its children, not just those with an index < 16. # must consider all of its children, not just those with an index < 16.