weaselab/versioned-map
2
0
Fork 0
Code Issues 4 Pull Requests Actions Packages Projects Releases Wiki Activity

Identify some FdbVersionedMap bugs

Browse Source
This commit is contained in:
Andrew Noyes
2024-05-28 14:01:51 -07:00
parent 1b5ed72ab9
commit 3aa192255e
1 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
FdbVersionedMap.cpp
View File

@@ -1203,16 +1203,14 @@ struct __attribute__((__visibility__("hidden"))) VersionedMap::Impl {
} }
versionedData.erase(param1, param2); versionedData.erase(param1, param2);
assert(param2 > param1); assert(param2 > param1);
// assert( assert(
// !versionedData.isClearContaining(versionedData.atLatest(), !versionedData.isClearContaining(versionedData.atLatest(), param1));
// param1));
versionedData.insert(param1, ValueOrClearToRef::clearTo(param2)); versionedData.insert(param1, ValueOrClearToRef::clearTo(param2));
} }
} }
} }
void setOldestVersion(int64_t oldestVersion) { void setOldestVersion(int64_t oldestVersion) {
return;
auto iter = mutationLog.begin(); auto iter = mutationLog.begin();
while (iter != mutationLog.end() && iter->first <= oldestVersion) { while (iter != mutationLog.end() && iter->first <= oldestVersion) {
for (const auto &m : iter->second.mutations) { for (const auto &m : iter->second.mutations) {
@@ -1238,8 +1236,6 @@ struct __attribute__((__visibility__("hidden"))) VersionedMap::Impl {
} }
versionedData.forgetVersionsBefore(oldestVersion); versionedData.forgetVersionsBefore(oldestVersion);
} }
// TODO
}; };
VersionedMap::Impl *internal_makeImpl(int64_t version) { VersionedMap::Impl *internal_makeImpl(int64_t version) {