weaselab/weaseljson
2
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

check WeaselJsonParser_create return value in Python bindings #26

Merged
andrew merged 1 commits from weaselbot/weaseljson:weaselbot/issue-23 into main 2026-06-22 18:52:47 +00:00
Conversation 0 Commits 1 Files Changed 2
+24
weaselbot commented 2026-06-22 06:29:31 +00:00
Member
Copy Link
Copy Source

Closes #23

Closes #23
weaselbot added 1 commit 2026-06-22 06:29:34 +00:00
check WeaselJsonParser_create return value in Python bindings
CI / build (-DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++, clang-arm64, ubuntu-latest-arm64, true) (pull_request) Successful in 1m3s
Details
CI / build (-DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++, gcc-arm64, ubuntu-latest-arm64, false) (pull_request) Successful in 54s
Details
CI / pre-commit (pull_request) Successful in 58s
Details
CI / build (-DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++, clang-amd64, ubuntu-latest-amd64, true) (pull_request) Successful in 1m37s
Details
CI / build (-DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++, gcc-amd64, ubuntu-latest-amd64, false) (pull_request) Successful in 1m30s
Details
a26e101191 
Raise ValueError from __init__ when the C constructor returns NULL,
instead of storing a NULL pointer that segfaults on parse()/reset().
Add defensive RuntimeError checks in parse() and reset() for closed
or failed parsers.

Add a test covering stackSize values that the C API rejects (-1, 0, 1, 2).

Fixes #23
andrew merged commit 3d7dc97471 into main 2026-06-22 18:52:47 +00:00
andrew deleted branch weaselbot/issue-23 2026-06-22 18:52:47 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
missing-test-coverage
Issues having to do with missing test coverage
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
andrew weaselbot
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: weaselab/weaseljson#26