schemagen: cache non-object $defs entries to avoid duplicate types #31

Merged

andrew merged 2 commits from weaselbot/weaseljson:weaselbot/issue-17 into main 2026-06-24 17:02:39 +00:00

Conversation 0 Commits 2 Files Changed 2

+57 -8

2 Commits

Author	SHA1	Message	Date
weaselbot	e155e0bbf4	schemagen: restore nullable tuple return for object schemas ... The previous change to cache object definitions started returning the bare TObj from build_type for object schemas, discarding the nullable flag. This caused nullable root objects to be emitted as plain structs instead of std::optional<RootInner>, breaking the nullable root tests. Return the (TObj, nullable) tuple so callers (including the root emitter) see the correct nullability again.	2026-06-24 09:51:19 -04:00
weaselbot	717f30099f	schemagen: cache non-object $defs entries to avoid duplicate types ... Extend the existing per-definition cache (`self._building`) to enum, array, and scalar $defs, not just object definitions. This ensures that multiple $refs to the same non-object definition reuse the same C++ type instead of generating Role, Role2, Role3, etc. - Cache the built (type, nullable) tuple under defname for enum, scalar, and array definitions. - Pre-register array definitions before recursing into items so $ref cycles resolve to the same TArr instance. - Store object definitions as (TObj, nullable) tuples so nullable object $defs also preserve their nullability when referenced. Add a regression test for issue #17 covering reused enum and array-of-enum $defs.	2026-06-23 22:16:34 -04:00