weaselab/weaseljson
2
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

schemagen: escape control characters in generated C++ string literals #48

Merged
andrew merged 1 commits from weaselbot/weaseljson:weaselbot/issue-35 into main 2026-06-30 16:30:23 +00:00
Conversation 0 Commits 1 Files Changed 2
+136 -6
weaselbot commented 2026-06-30 16:26:17 +00:00
Member
Copy Link
Copy Source

Closes #35

Closes #35
weaselbot added 1 commit 2026-06-30 16:26:18 +00:00
schemagen: escape control characters in generated C++ string literals
CI / pre-commit (pull_request) Successful in 53s
Details
CI / build (-DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++, clang-arm64, ubuntu-latest-arm64, true) (pull_request) Successful in 53s
Details
CI / build (-DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++, clang-amd64, ubuntu-latest-amd64, true) (pull_request) Successful in 1m32s
Details
CI / build (-DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++, gcc-arm64, ubuntu-latest-arm64, false) (pull_request) Successful in 52s
Details
CI / build (-DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++, gcc-amd64, ubuntu-latest-amd64, false) (pull_request) Successful in 1m28s
Details
681892107f 
Fixes #35.

Add a helper to escape C++ string literals so that JSON control characters
(\n, \r, \t, and other bytes below 0x20) are emitted as escape sequences
instead of raw bytes. Use it for:

- field comments that include the JSON property key
- object key comparison literals in matchKey()
- enum name arrays

Also add regression tests that generate and syntax-check headers for
schemas containing newlines and other control characters in property keys
and enum values.
andrew scheduled this pull request to auto merge when all checks succeed 2026-06-30 16:27:51 +00:00
andrew merged commit f6617a1558 into main 2026-06-30 16:30:23 +00:00
andrew deleted branch weaselbot/issue-35 2026-06-30 16:30:24 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
missing-test-coverage
Issues having to do with missing test coverage
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
andrew weaselbot
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: weaselab/weaseljson#48