weaselab/weaseljson
2
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

schemagen: reject self-referential array $ref cycles instead of crashing #49

Merged
andrew merged 1 commits from weaselbot/weaseljson:weaselbot/issue-33 into main 2026-06-30 16:37:03 +00:00
Conversation 0 Commits 1 Files Changed 2
+103
weaselbot commented 2026-06-30 16:29:57 +00:00
Member
Copy Link
Copy Source

Closes #33

Closes #33
weaselbot added 1 commit 2026-06-30 16:29:58 +00:00
schemagen: reject self-referential array $ref cycles instead of crashing
CI / build (-DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++, clang-arm64, ubuntu-latest-arm64, true) (pull_request) Successful in 55s
Details
CI / build (-DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++, gcc-arm64, ubuntu-latest-arm64, false) (pull_request) Successful in 51s
Details
CI / pre-commit (pull_request) Successful in 52s
Details
CI / build (-DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++, clang-amd64, ubuntu-latest-amd64, true) (pull_request) Successful in 1m32s
Details
CI / build (-DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++, gcc-amd64, ubuntu-latest-amd64, false) (pull_request) Successful in 1m26s
Details
ababd3a8fd 
Cyclic array definitions (directly or through a chain of array $defs)
created a self-referential TArr, which then caused infinite recursion in
base_cpp, storage_cpp, and _walk_arrays.

Object-only cycles are already broken with std::unique_ptr, but
array-only cycles have no object edge for break_cycles to cut.

Detect them after building an array's items by following TArr.elem links
and raise a clear GenError so generation fails gracefully rather than
overflowing the Python stack.

Closes #33
andrew merged commit d281c35811 into main 2026-06-30 16:37:03 +00:00
andrew deleted branch weaselbot/issue-33 2026-06-30 16:37:04 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
missing-test-coverage
Issues having to do with missing test coverage
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
andrew weaselbot
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: weaselab/weaseljson#49