weaselab/weaseljson
2
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

schemagen: reject absent additionalProperties #58

Merged
andrew merged 1 commits from weaselbot/weaseljson:weaselbot/issue-55 into main 2026-07-20 18:06:54 +00:00
Conversation 0 Commits 1 Files Changed 4
+55 -15
weaselbot commented 2026-07-20 02:06:38 +00:00
Member
Copy Link
Copy Source

Closes #55

Closes #55
weaselbot added 1 commit 2026-07-20 02:06:39 +00:00
schemagen: reject absent additionalProperties
CI / build (-DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++, clang-arm64, ubuntu-latest-arm64, true) (pull_request) Successful in 57s
Details
CI / build (-DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++, gcc-arm64, ubuntu-latest-arm64, false) (pull_request) Successful in 50s
Details
CI / pre-commit (pull_request) Successful in 52s
Details
CI / build (-DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++, clang-amd64, ubuntu-latest-amd64, true) (pull_request) Successful in 1m41s
Details
CI / build (-DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++, gcc-amd64, ubuntu-latest-amd64, false) (pull_request) Successful in 1m29s
Details
86b58e83cb 
Per the README contract, an object schema without an explicit
`additionalProperties` was documented as rejected at generation time,
but the code defaulted it to `false` and silently generated a strict
parser that rejects valid documents with extra properties.

Make the code match the documented contract by raising GenError when
`additionalProperties` is absent, with a clear message instructing the
author to set it explicitly to false. Update the README prose section
to list absent additionalProperties alongside true, and fix existing
schemas and tests to declare additionalProperties explicitly.

Closes #55
andrew merged commit c44b0262bc into main 2026-07-20 18:06:54 +00:00
andrew deleted branch weaselbot/issue-55 2026-07-20 18:06:54 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
missing-test-coverage
Issues having to do with missing test coverage
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
andrew weaselbot
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: weaselab/weaseljson#58